Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide current semester if show all is pressed and highlight current se… #1205

Conversation

SebiWrn
Copy link
Contributor

@SebiWrn SebiWrn commented Oct 23, 2023

Motivation and Context

Fixes #1184

Description

Currently selected semester will be highlighted in semester list but won't be shown twice at the top

Steps for Testing

On the main page just click show all on the semesters list

Screenshots

semester_selection_0
semester_selection_1

@SebiWrn SebiWrn linked an issue Oct 23, 2023 that may be closed by this pull request
@github-actions
Copy link

Your Testserver will be ready at https://1205.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. 👍 I would only suggest some minor style changes in this case.

web/template/home.gohtml Outdated Show resolved Hide resolved
web/template/home.gohtml Outdated Show resolved Hide resolved
SebiWrn and others added 2 commits November 19, 2023 17:22
Co-authored-by: Alexander Stephan <[email protected]>
Co-authored-by: Alexander Stephan <[email protected]>
Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks great now! 👍

@alexanderstephan alexanderstephan merged commit ff094d4 into dev Nov 20, 2023
8 checks passed
@alexanderstephan alexanderstephan deleted the 1184-semester-selection-shows-currently-selected-semester-twice branch November 20, 2023 16:55
SebiWrn added a commit that referenced this pull request May 7, 2024
#1205)

Currently selected semester will be highlighted in semester list but won't be shown twice at the top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semester selection shows currently selected semester twice
2 participants